build: Use temporary file for can_compile #1497
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The can_compile function in build.rs previously invoked rustc with -o -, which causes rustc to attempt to create a temporary metadata directory in the current working directory. When building with Portage for ChromeOS, this happens in a sandbox where the current working directory is not writeable, resulting in a sandbox access violation. This change modifies the can_compile function to use a temporary directory for the output file. This forces rustc to create the temporary file in a writeable location, avoiding the sandbox issue.
|
Thanks! |
|
This is now released in rustix 1.1.1. |
...and it has been leaking a random file into my (kudos for at least giving me a chance to understand where it's coming from by encoding the source in the file name, though) |
|
Thanks for the report. I'll fix it and send a separate PR next week. |
keiichiw
added a commit
to keiichiw/rustix
that referenced
this pull request
Sep 26, 2025
The `can_compile` utility writes its temporary output file to the system's global temporary directory. This can clutter the host system with build artifacts. By using Cargo's `OUT_DIR`, the temporary file is written to a directory specific to the build, ensuring that build artifacts are contained within the project's build output and do not mess up the host system. Follow-up to bytecodealliance#1497.
|
FYI: #1526 is the follow-up PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
can_compilefunction in build.rs previously invokedrustcwith-o -, which causesrustcto attempt to create a temporary metadata directory in the current working directory.When building this in another build system such as Portage, this happens in a sandbox where the current working directory is not writeable, resulting in a sandbox access violation.
This change modifies the
can_compilefunction to use a temporary directory for the output file. This forcesrustcto create the temporary file in a writeable location, avoiding the sandbox issue.