Time Measure & Support for Multiple Measures #285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While imperfect, this is still useful data that anchors benchmark iterations to a number that is more meaningful to humans sometimes. Combined with the ability to capture multiple measures, this is pretty useful to have available.
Previously, only a single measure type could be requested. Often, we might want to capture multiple measures on a benchmark run as different measurements might provide a more complete picture of a given benchmark iteration.
posborne
force-pushed
the
support-multiple-benchmark-measures
branch
from
8fd0df4 to
6e8357d
Compare
posborne
added a commit
to posborne/sightglass
that referenced
this pull request
Apr 28, 2025
* Add simple time measurement While imperfect, this is still useful data that anchors benchmark iterations to a number that is more meaningful to humans sometimes. Combined with the ability to capture multiple measures, this is pretty useful to have available. * Add support for capturing multiple measurements Previously, only a single measure type could be requested. Often, we might want to capture multiple measures on a benchmark run as different measurements might provide a more complete picture of a given benchmark iteration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can now, for example, do the following to capture timing, cycles, and perf-counters data on a single run...