Add clippy to ci (and fixes) #290
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Author
|
Failures appear to be from other CI bitrot unrelated to these changes; I'll separate off another PR to hopefully get baseline CI to pass and then this can be revisited on top of that. |
Merged
Note: clippy checks will fail at this commit. Fixes follow in subsequent commits.
- Fix redundant imports and unused lifetimes - Update method calls to use modern patterns (is_none_or, as_deref) - Add missing Default implementations for new() functions - Fix needless borrows and improve type conversions - Use write_all instead of write for complete writes - Simplify conditional patterns using if let - A mixed bag of other small changes, mostly auto-fixed by cargo fix.
posborne
force-pushed
the
add-clippy-to-ci
branch
from
bb867b3 to
01df9e3
Compare
Collaborator
Author
|
Rebased; r? @fitzgen -- adding clippy isn't essential, but I have a train of a few other changes and wanted to get that code lint-free and it seemed valuable to just enforce that for the tree. Updates across the tree are mostly mechanical lint fixes. |
fitzgen
approved these changes
Nov 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on another change I wanted to run clippy but there were a bunch of existing warnings as it has not historically been enabled in CI for sightglass; add it to CI and fix the issues that it warned about.
I made the fixes as minimal as possible, with most being done by the tool itself. Likewise for the CI changes; there's definitely other stuff that could be updated (and likely may be in future changes). For now, just trying to get things clippy-clean.