-
Notifications
You must be signed in to change notification settings - Fork 21
Try to enhance no std support #98
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
} | ||
} | ||
|
||
impl RuntimeBuilder { | ||
/// create a named module runtime builder |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A new entrance for builder, make import module with variant names easier.
@lum1n0us Can you give me some suggestions? I think this proposal would be helpful. |
Love it. We might rebase this after PR #102 has been merged. I thought the idea was about creating the smallest possible program without using the standard library, but it appears to be going in a different direction. Am I wrong? |
I think what I've done aligns with the principles advocated by Rust. However, it was inspired by this discussion: |
Library users certainly don't need to worry. If a library enables Using |
Any updates ? |
Actually, I was thinking we could completely use something like embedded-io to handle file streams. But this involves considerable changes, and I’m not sure whether it’s necessary to proceed. |
Why not disable such feature because WAMR can works without files when using your own abstraction layer (not the one included within WAMR) or disabling such features. Only create alloc is required in the end. |
This is already the case, there is no file system related code when no default features. My suggestion is to use io::read to read the stream data. If wasm is large. @lum1n0us Could you review this PR? |
Currently, only loading module through file uses std. We can consider excluding this part to make lib support no-std.