-
Notifications
You must be signed in to change notification settings - Fork 60
Develop bindings for WASI versions in parallel #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+5,316
−494
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
d2dd1af
Develop bindings for WASI versions in parallel
alexcrichton 73ba23b
Fixes for CI
alexcrichton fe6437e
Update msrv to 78
alexcrichton 4f51f86
Cancel in-flight CI
alexcrichton ac9fece
Update msrv
alexcrichton 71a6f08
Download precompiled binary of wit-bindgen
alexcrichton 8b45ce9
Downgrade one point
alexcrichton fbdf1df
Remove version suffix
alexcrichton File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| name: 'Install Rust toolchain' | ||
| description: 'Install a rust toolchain' | ||
|
|
||
| inputs: | ||
| toolchain: | ||
| description: 'Default toolchan to install' | ||
| required: false | ||
| default: 'stable' | ||
|
|
||
| runs: | ||
| using: composite | ||
| steps: | ||
| - name: Install Rust | ||
| shell: bash | ||
| id: select | ||
| run: | | ||
| # Determine MSRV as N in `1.N.0` by looking at the `rust-version` | ||
| # located in the root `Cargo.toml`. | ||
| msrv=$(grep 'rust-version.*1' Cargo.toml | sed 's/.*\.\([0-9]*\)\..*/\1/') | ||
|
|
||
| if [ "${{ inputs.toolchain }}" = "msrv" ]; then | ||
| echo "version=1.$msrv.0" >> "$GITHUB_OUTPUT" | ||
| else | ||
| echo "version=${{ inputs.toolchain }}" >> "$GITHUB_OUTPUT" | ||
| fi | ||
|
|
||
| - name: Install Rust | ||
| shell: bash | ||
| run: | | ||
| rustup set profile minimal | ||
| rustup update "${{ steps.select.outputs.version }}" --no-self-update | ||
| rustup default "${{ steps.select.outputs.version }}" | ||
|
|
||
| # Save disk space by avoiding incremental compilation. Also turn down | ||
| # debuginfo from 2 to 0 to help save disk space. | ||
| cat >> "$GITHUB_ENV" <<EOF | ||
| CARGO_INCREMENTAL=0 | ||
| CARGO_PROFILE_DEV_DEBUG=0 | ||
| CARGO_PROFILE_TEST_DEBUG=0 | ||
| EOF | ||
|
|
||
| # Deny warnings on CI to keep our code warning-free as it lands in-tree. | ||
| echo RUSTFLAGS="-D warnings" >> "$GITHUB_ENV" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Empty file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"Bytecode Alliance"? "Alex Crichton"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh nowadays Cargo/crates.io basically ignore this field and it's not even generated by default, and AFAIK the recommendation is to remove it so I went ahead and cleaned it up here