Use venv to install llvm dependencies and run build script #4514
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loganek
requested review from
lum1n0us,
no1wudi,
TianlongLiang,
wenyongh,
xujuntwt95329 and
yamt
as code owners
lum1n0us
added
the
enhancement
lum1n0us
approved these changes
Jul 29, 2025
TianlongLiang
approved these changes
Jul 29, 2025
|
Maybe we should add venv/ to .gitignore? What do you think |
yamt
reviewed
Jul 29, 2025
Installing pip packages system-wide is no longer recommended, therefore we create virtual environment for setting up the build environment for LLVM.
loganek
force-pushed
the
loganek/venv-llvm
branch
from
4011626 to
57e2354
Compare
There's no venv directory created as part of this process; instead, we create a venv folder in the system's temp directory. |
|
Got it, thanks |
yamt
reviewed
Aug 5, 2025
| trap cleanup EXIT INT TERM | ||
|
|
||
| /usr/bin/env python3 -m venv --clear "$TEMP_DIR" | ||
| source "$TEMP_DIR/bin/activate" |
|
|
||
| trap cleanup EXIT INT TERM | ||
|
|
||
| /usr/bin/env python3 -m venv --clear "$TEMP_DIR" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Installing pip packages system-wide is no longer recommended, therefore we create virtual environment for setting up the build environment for LLVM.