Skip to content

fix(core): allow transitive fetching local deps #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thomastaylor312 merged 3 commits into from
Dec 10, 2024
Merged

fix(core): allow transitive fetching local deps #135

thomastaylor312 merged 3 commits into from
Dec 10, 2024

Conversation

@brooksmtownsend
Copy link
Contributor

@brooksmtownsend brooksmtownsend commented Dec 5, 2024

  • fix(core): use local override over registry dep
  • test(core): add test for transitive local dep
  • deps: enable tracing-subscriber ansi feature

Fixes #132

This PR:

  1. Fixes an issue with transitive dependency fetching where a local dependency of a local dependency was treated as a registry dependency, which would fail
  2. Adds a test for the above case to ensure that this works
  3. Enables the ansi feature of tracing-subscriber so we can all have colored logging output <3

joonas
joonas reviewed Dec 6, 2024
View reviewed changes
joonas
joonas reviewed Dec 6, 2024
View reviewed changes
@brooksmtownsend
fix(core): use local override over registry dep
bd0bc24 
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>

fix: bad log prefix

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend
test(core): add test for transitive local dep
1b1fec0 
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend
deps(wkg): enable tracing-subscriber ansi feature
699055e 
Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>

ansi on wkg instead

Signed-off-by: Brooks Townsend <brooksmtownsend@gmail.com>
@brooksmtownsend brooksmtownsend force-pushed the fix/transitive-fetch-local-deps branch from 3795252 to 699055e Compare December 9, 2024 14:36
@thomastaylor312 thomastaylor312 merged commit fd2c893 into bytecodealliance:main Dec 10, 2024
3 checks passed
@brooksmtownsend brooksmtownsend deleted the fix/transitive-fetch-local-deps branch December 10, 2024 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@joonas joonas joonas approved these changes

@thomastaylor312 thomastaylor312 thomastaylor312 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[BUG] Fetching order causes inconsistent results

3 participants

@brooksmtownsend @joonas @thomastaylor312