Skip to content

Replace Marshal with Unsafe #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

andreakarasho
Copy link

No description provided.

@BasGeertsema
Copy link

I noticed the warning in the documentation. It seems to me that we actually want the size of the unmanaged view of the type? In that case we would need to use Marshal.SizeOf, as it is now.

@andreakarasho
Copy link
Author

Partially reverted to the Marshalversion but keeping the constraint version.

@jsturtevant
Copy link
Contributor

Should we try using the internal structs version before updating this? #332 (comment)

I think using the internal structs would remove the need for this change

@BasGeertsema
Copy link

Should we try using the internal structs version before updating this? #332 (comment)

I think using the internal structs would remove the need for this change

I agree, that would be a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants