-
Notifications
You must be signed in to change notification settings - Fork 24
Implement preopened_dir using set_mapped_directory setting #498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
saulecabrera
merged 5 commits into
bytecodealliance:main
from
william-stacken:preopened-dir
Sep 9, 2025
Merged
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
0400633
Implement preopened_dir using set_mapped_directory setting
alhafoudh cea0c26
Add tests for mapped directories
william-stacken be6813a
Use rust struct instead of nested RArrays
william-stacken 4bd4e38
Model enums as SymbolEnums
william-stacken f4f7447
Lazily convert ruby MappedDirectory values to rust
william-stacken File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should the creation of this
RArray
be moved under the if on line 267? Else we'd be creating an array even though it won't be needed.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would we consider storing these in a
Vec<SomeStruct>
instead of nestedRArrays
?Pros:
RArray
is gone).Array
to store the arguments for each call.WasiCtxBuilder.preopened_dir
-compatible args will show up immediately, not delayed in a future call. Tiny detail, but makes errors easier to debug.Cons:
I didn't mean to hijack the PR, feel free to ignore if not useful.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the suggestion is reasonable, personally the main advantage that I see, is not having to incur in the overhead of creating a Ruby array each time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea, I switched to using a
Vec
and there are still no garbage collection problems.