x64: Remove older pmul* from codegen (#10854)

* remove old pmul* instructions from codegen

* prtest:full

Author: rahulchaphalkar

cranelift/codegen/src/isa/x64/inst.isle

@@ -792,13 +792,6 @@
             Pmovzxwd
             Pmovzxwq
             Pmovzxdq
-            Pmuldq
-            Pmulhw
-            Pmulhuw
-            Pmulhrsw
-            Pmulld
-            Pmullw
-            Pmuludq
             Pshufb
             Pshufd
             Ptest

cranelift/codegen/src/isa/x64/inst/args.rs

@@ -868,13 +868,6 @@ pub enum SseOpcode {
     Pmovzxwd,
     Pmovzxwq,
     Pmovzxdq,
-    Pmuldq,
-    Pmulhw,
-    Pmulhuw,
-    Pmulhrsw,
-    Pmulld,
-    Pmullw,
-    Pmuludq,
     Pshufb,
     Pshufd,
     Ptest,
@@ -926,10 +919,6 @@ impl SseOpcode {
             | SseOpcode::Pcmpgtw
             | SseOpcode::Pcmpgtd
             | SseOpcode::Pmaddwd
-            | SseOpcode::Pmulhw
-            | SseOpcode::Pmulhuw
-            | SseOpcode::Pmullw
-            | SseOpcode::Pmuludq
             | SseOpcode::Pshufd
             | SseOpcode::Ucomisd
             | SseOpcode::Pshuflw
@@ -939,7 +928,6 @@ impl SseOpcode {
             | SseOpcode::Pabsw
             | SseOpcode::Pabsd
             | SseOpcode::Palignr
-            | SseOpcode::Pmulhrsw
             | SseOpcode::Pshufb
             | SseOpcode::Pmaddubsw
             | SseOpcode::Movddup => SSSE3,
@@ -962,8 +950,6 @@ impl SseOpcode {
             | SseOpcode::Pmovzxwd
             | SseOpcode::Pmovzxwq
             | SseOpcode::Pmovzxdq
-            | SseOpcode::Pmuldq
-            | SseOpcode::Pmulld
             | SseOpcode::Ptest
             | SseOpcode::Roundps
             | SseOpcode::Roundpd
@@ -1053,13 +1039,6 @@ impl fmt::Debug for SseOpcode {
             SseOpcode::Pmovzxwd => "pmovzxwd",
             SseOpcode::Pmovzxwq => "pmovzxwq",
             SseOpcode::Pmovzxdq => "pmovzxdq",
-            SseOpcode::Pmuldq => "pmuldq",
-            SseOpcode::Pmulhw => "pmulhw",
-            SseOpcode::Pmulhuw => "pmulhuw",
-            SseOpcode::Pmulhrsw => "pmulhrsw",
-            SseOpcode::Pmulld => "pmulld",
-            SseOpcode::Pmullw => "pmullw",
-            SseOpcode::Pmuludq => "pmuludq",
             SseOpcode::Pshufb => "pshufb",
             SseOpcode::Pshufd => "pshufd",
             SseOpcode::Ptest => "ptest",

cranelift/codegen/src/isa/x64/inst/emit.rs

@@ -1763,13 +1763,6 @@ pub(crate) fn emit(
                 SseOpcode::Pcmpgtd => (LegacyPrefixes::_66, 0x0F66, 2),
                 SseOpcode::Pcmpgtq => (LegacyPrefixes::_66, 0x0F3837, 3),
                 SseOpcode::Pmaddwd => (LegacyPrefixes::_66, 0x0FF5, 2),
-                SseOpcode::Pmuldq => (LegacyPrefixes::_66, 0x0F3828, 3),
-                SseOpcode::Pmulhw => (LegacyPrefixes::_66, 0x0FE5, 2),
-                SseOpcode::Pmulhrsw => (LegacyPrefixes::_66, 0x0F380B, 3),
-                SseOpcode::Pmulhuw => (LegacyPrefixes::_66, 0x0FE4, 2),
-                SseOpcode::Pmulld => (LegacyPrefixes::_66, 0x0F3840, 3),
-                SseOpcode::Pmullw => (LegacyPrefixes::_66, 0x0FD5, 2),
-                SseOpcode::Pmuludq => (LegacyPrefixes::_66, 0x0FF4, 2),
                 SseOpcode::Pshufb => (LegacyPrefixes::_66, 0x0F3800, 3),
                 _ => unimplemented!("Opcode {:?} not implemented", op),
             };

cranelift/codegen/src/isa/x64/inst/emit_tests.rs

@@ -2682,36 +2682,6 @@ fn test_x64_emit() {
         "pavgw   %xmm8, %xmm1, %xmm8",
     ));
 
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmuldq, RegMem::reg(xmm4), w_xmm15),
-        "66440F3828FC",
-        "pmuldq  %xmm15, %xmm4, %xmm15",
-    ));
-
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmulhw, RegMem::reg(xmm9), w_xmm1),
-        "66410FE5C9",
-        "pmulhw  %xmm1, %xmm9, %xmm1",
-    ));
-
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmulhuw, RegMem::reg(xmm7), w_xmm9),
-        "66440FE4CF",
-        "pmulhuw %xmm9, %xmm7, %xmm9",
-    ));
-
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmulld, RegMem::reg(xmm15), w_xmm6),
-        "66410F3840F7",
-        "pmulld  %xmm6, %xmm15, %xmm6",
-    ));
-
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmullw, RegMem::reg(xmm14), w_xmm1),
-        "66410FD5CE",
-        "pmullw  %xmm1, %xmm14, %xmm1",
-    ));
-
     insns.push((
         Inst::xmm_rm_r_evex(Avx512Opcode::Vpmullq, xmm10, RegMem::reg(xmm14), w_xmm1),
         "62D2AD0840CE",
@@ -2748,12 +2718,6 @@ fn test_x64_emit() {
         "vpermi2b %xmm1, %xmm0, %xmm2, %xmm2",
     ));
 
-    insns.push((
-        Inst::xmm_rm_r(SseOpcode::Pmuludq, RegMem::reg(xmm8), w_xmm9),
-        "66450FF4C8",
-        "pmuludq %xmm9, %xmm8, %xmm9",
-    ));
-
     insns.push((
         Inst::xmm_rm_r(SseOpcode::Pmaddwd, RegMem::reg(xmm8), w_xmm1),
         "66410FF5C8",