Update windows-sys crate to its latest major version (#11199)

Keeping up-to-date

Author: alexcrichton

Cargo.lock

@@ -349,7 +349,7 @@ object = { version = "0.36.5", default-features = false, features = ['read_core'
 gimli = { version = "0.31.0", default-features = false, features = ['read'] }
 addr2line = { version = "0.24.1", default-features = false }
 anyhow = { version = "1.0.93", default-features = false }
-windows-sys = "0.59.0"
+windows-sys = "0.60.0"
 env_logger = "0.11.5"
 log = { version = "0.4.27", default-features = false }
 clap = { version = "4.5.17", default-features = false, features = ["std", "derive"] }

Cargo.toml

@@ -238,13 +238,7 @@ impl WorkerThread {
         // https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-setthreadpriority
         // https://docs.microsoft.com/en-us/windows/win32/procthread/scheduling-priorities
 
-        if unsafe {
-            SetThreadPriority(
-                GetCurrentThread(),
-                THREAD_MODE_BACKGROUND_BEGIN.try_into().unwrap(),
-            )
-        } == 0
-        {
+        if unsafe { SetThreadPriority(GetCurrentThread(), THREAD_MODE_BACKGROUND_BEGIN) } == 0 {
             warn!(
                 "Failed to lower worker thread priority. It might affect application performance."
             );

crates/cache/src/worker.rs

@@ -35,7 +35,7 @@ impl BackendInner for WinMLBackend {
 
     fn load(&mut self, builders: &[&[u8]], target: ExecutionTarget) -> Result<Graph, BackendError> {
         if builders.len() != 1 {
-            return Err(BackendError::InvalidNumberOfBuilders(1, builders.len()).into());
+            return Err(BackendError::InvalidNumberOfBuilders(1, builders.len()));
         }
 
         let model_stream = InMemoryRandomAccessStream::new()?;
@@ -83,7 +83,7 @@ unsafe impl Sync for WinMLGraph {}
 
 impl BackendGraph for WinMLGraph {
     fn init_execution_context(&self) -> Result<ExecutionContext, BackendError> {
-        let device = LearningModelDevice::Create(self.device_kind.clone())?;
+        let device = LearningModelDevice::Create(self.device_kind)?;
         let session = LearningModelSession::CreateFromModelOnDevice(&self.model, &device)?;
         let box_: Box<dyn BackendExecutionContext> = Box::new(WinMLExecutionContext::new(session));
         Ok(box_.into())

crates/wasi-nn/src/backend/winml.rs

@@ -25,12 +25,11 @@ impl UnwindRegistration {
         assert!(unwind_info as usize % 4 == 0);
         let unit_len = mem::size_of::<Entry>();
         assert!(unwind_len % unit_len == 0);
-        if RtlAddFunctionTable(
+        if !RtlAddFunctionTable(
             unwind_info as *mut Entry,
             (unwind_len / unit_len).try_into().unwrap(),
             base_address as _,
-        ) == 0
-        {
+        ) {
             bail!("failed to register function table");
         }