x64: Fix has_native_fma
#11794
Open
x64: Fix has_native_fma
#11794
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit synchronizes the implementation of lowering and `has_native_fma` where lowering requires both AVX + FMA but `has_native_fma` was just testing FMA, meaning that if `has_fma` was enabled but `has_avx` was disabled it would be possible to generate a link-time error with Wasmtime.
github-actions
bot
added
cranelift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit synchronizes the implementation of lowering and
has_native_fmawhere lowering requires both AVX + FMA buthas_native_fmawas just testing FMA, meaning that ifhas_fmawas enabled buthas_avxwas disabled it would be possible to generate a link-time error with Wasmtime.