Fix Module::image_range to include non-text part of module.
#12302
+49
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This method is informational for embedders to be able to, for example, ensure an image in memory is `mlock`'d (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition.
github-actions
bot
added
the
wasmtime:api
Contributor
alexcrichton
approved these changes
Jan 9, 2026
Member
alexcrichton
left a comment
alexcrichton
left a comment
There was a problem hiding this comment.
r=me with @jeffcharles's comment
Member
Author
|
Ah, missed that -- thanks! |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
alexcrichton
pushed a commit
to alexcrichton/wasmtime
that referenced
this pull request
Jan 9, 2026
…dealliance#12302) * Fix `Module::image_range` to include non-text part of module. This method is informational for embedders to be able to, for example, ensure an image in memory is `mlock`'d (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition. * Components as well as core modules. * Ignore new tests in miri.
alexcrichton
added a commit
that referenced
this pull request
Jan 9, 2026
#12307) * Fix `Module::image_range` to include non-text part of module. This method is informational for embedders to be able to, for example, ensure an image in memory is `mlock`'d (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition. * Components as well as core modules. * Ignore new tests in miri. Co-authored-by: Chris Fallin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is informational for embedders to be able to, for example, ensure an image in memory is
mlock'd (not swapped out). In the refactors around the StoreCode/EngineCode split, I mistakenly redefined this to only the text section. This is not a Wasm execution correctness issue but may lead to performance issues if an embedder relies on this behavior. This PR fixes the definition.Fixes #12284.