Skip to content

Make some error message assertions more-precisely test what we care about #12305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fitzgen merged 1 commit into from
Jan 9, 2026
Merged

Make some error message assertions more-precisely test what we care about #12305

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 29 additions & 17 deletions crates/wasmtime/src/engine/serialization.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,6 +479,15 @@ mod test {
Ok(())
}

fn assert_contains(error: &Error, msg: &str) {
let msg = msg.trim();
if error.chain().any(|e| e.to_string().contains(msg)) {
return;
}

panic!("failed to find:\n\n'''{msg}\n'''\n\nwithin error message:\n\n'''{error:?}'''")
}

#[test]
fn test_cranelift_flags_mismatch() -> Result<()> {
let engine = Engine::default();
Expand All @@ -490,13 +499,16 @@ mod test {

match metadata.check_compatible(&engine) {
Ok(_) => unreachable!(),
Err(e) => assert!(format!("{e:?}").starts_with(
"\
compilation settings of module incompatible with native host

Caused by:
setting \"preserve_frame_pointers\" is configured to Bool(false) which is not supported"
)),
Err(e) => {
assert_contains(
&e,
"compilation settings of module incompatible with native host",
);
assert_contains(
&e,
"setting \"preserve_frame_pointers\" is configured to Bool(false) which is not supported",
);
}
}

Ok(())
Expand All @@ -513,16 +525,16 @@ Caused by:

match metadata.check_compatible(&engine) {
Ok(_) => unreachable!(),
Err(e) => assert!(
format!("{e:?}").starts_with(
"\
compilation settings of module incompatible with native host

Caused by:
don't know how to test for target-specific flag \"not_a_flag\" at runtime",
),
"bad error {e:?}",
),
Err(e) => {
assert_contains(
&e,
"compilation settings of module incompatible with native host",
);
assert_contains(
&e,
"don't know how to test for target-specific flag \"not_a_flag\" at runtime",
);
}
}

Ok(())
Expand Down