Initial fixed-length list implementation #1277
Conversation
|
I have a newer version at https://github.com/cpetig/wit-bindgen/tree/work-in-progress which tests more in depth and also supports C++, I need to separate and clean up that one and then push it here for review. |
|
Also this requires bytecodealliance/wasmtime#10619 , and a very recent version of wasm-component-ld for the tests to pass. |
cpetig
force-pushed
the
fixed_size_list
branch
from
7f2f236 to
ed27ed6
Compare
cpetig
force-pushed
the
fixed_size_list
branch
from
ed27ed6 to
e7ce6f0
Compare
|
This is ready, but depends on bytecodealliance/wasmtime#10619 for successful tests. |
| } | ||
| ret.arg("--invoke=run()"); | ||
| ret.arg("--invoke=run()") | ||
| .arg("-Wcomponent-model-fixed-size-list"); |
There was a problem hiding this comment.
For this, for now, this'll go in .github/workflows/main.yml. In retrospect this should go in the test file itself with some sort of //@ ... option or something like that. I can investigate poking around with the latter, so if you want to move this line itself to .github/ that should be sufficient.
There was a problem hiding this comment.
In #1497 I'm moving these flags to test files themselves
|
This still has a limitation: The generated Rust and C++ code can't handle non-Copy/POD types. For Functional Safety this isn't an issue as you need to avoid putting string or list into a fixed size array anyway, resources might still make some sense. I created #1501 to track this limitation. |
cpetig
changed the title
|
TODO: Check for correct usage of "fixed-length" over "fixed-size" |
2 participants
See WebAssembly/component-model#384 for the commit which added fixed size lists to the component model standard documents.