fix(go): casting unsafe pointer to uintptr type #1493
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mport_* functions Signed-off-by: Andrew Steurer <[email protected]>
Signed-off-by: Andrew Steurer <[email protected]>
Contributor
Author
|
Also, the CI / Async test ran for a VERY long time, and I'm not sure why...When I ran them locally, the go tests passed without issue. |
Collaborator
Yes, please. Ideally it would be a minimal '*.wit' file under tests/codegen that hits the case you fixed.
Thanks for pointing that out. Looking back through https://github.com/bytecodealliance/wit-bindgen/actions, I'm seeing several six hour CI runs prior to this PR. I'll dig into it. |
Collaborator
|
I've opened #1495 for the CI issue. |
Signed-off-by: Andrew Steurer <[email protected]>
Contributor
Author
|
@dicej When you have a moment, this is ready for review |
Merged
via the queue into
bytecodealliance:main
with commit Jan 12, 2026
2d98864
26 of 27 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where
wit_async.SubtaskWait(uint32(wasm_import_method_*(params, returnArea)))will throw a compilation error because it expectsparamsto be typeuintptr. I discovered this when generating the bindings forwasi:[email protected].@dicej will you let me know if this needs additional test coverage?