Add an example tcp_echo_server_non_blocking
#32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for submitting this. We will want to exercise this with a test like we do for the tcp_echo_server. As far as the style, this uses |
Done. It does need a test, but due to bytecodealliance/wasmtime#9667, I haven’t found a good way to write one yet. |
pchickey
reviewed
Dec 28, 2024
|
|
||
| futures_lite::future::poll_fn(|cx| { | ||
| if let Poll::Ready(_) = listening_task.as_mut().poll(cx) { | ||
| return Poll::Ready(()); |
There was a problem hiding this comment.
I don't think we want to return as Ready until both the Listener is ready and the stream tasks are all complete.
There was a problem hiding this comment.
Sorry, I didn't quite understand what you meant. Could you please tell me your thoughts directly?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#25