Skip to content

Workaround for unexpected stream break #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Heap-Hop
Copy link

@pchickey
Copy link
Contributor

I'd like to investigate fixing this bug in wasmtime before we commit any workarounds here. I may not have time to do that before the holiday weekend, but I will hopefully do so next week.

@pchickey
Copy link
Contributor

I rewrote the reactor and streams abstractions in #35 #37. Can we see if this behavior is still present since those fixes?

@pchickey pchickey mentioned this pull request Dec 28, 2024
@pchickey
Copy link
Contributor

#60 replaces these changes to the library. We should still land improvements to the tests, though!

@Heap-Hop
Copy link
Author

Sorry for the late reply, I will take deep look at the latest changes.

@Heap-Hop
Copy link
Author

Heap-Hop commented Feb 7, 2025

I tested non_blocking_tcp_example #32 with the latest main branch, and it works well!

I believe this workaround PR is no longer necessary.

@Heap-Hop Heap-Hop closed this Feb 7, 2025
@Heap-Hop Heap-Hop deleted the workaround_fix_unexpected_stream_read branch February 7, 2025 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants