adding .json() method for better ergonomics similar to reqwest crate
#63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchickey
reviewed
Feb 17, 2025
| @@ -26,8 +31,6 @@ impl BodyKind { | |||
| .parse::<u64>() | |||
| .map_err(|_| InvalidContentLength)?; | |||
| Ok(BodyKind::Fixed(content_length)) | |||
| } else if headers.contains_key(TRANSFER_ENCODING) { | |||
| Ok(BodyKind::Chunked) | |||
There was a problem hiding this comment.
Not sure what this deletion is for - was there a bug here?
There was a problem hiding this comment.
Clippy spotted this. The else block below it returned the same thing, Ok(BodyKind::Chunked)
There was a problem hiding this comment.
Thanks, I didn't even consider that, I was focused on the transfer encoding aspect.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves ergonomics for working with JSON request and responses:
response.body_mut().json::<T>().await?;Request::post("https://postman-echo.com/post").json(&data)?;