test(nomerge): add porcupine linearizability test#263
Open
jmasters-git wants to merge 1 commit intobytedance:mainfrom
Open
test(nomerge): add porcupine linearizability test#263jmasters-git wants to merge 1 commit intobytedance:mainfrom
jmasters-git wants to merge 1 commit intobytedance:mainfrom
Conversation
Add a per-key linearizability test for StringMap using the porcupine checker. The test runs 16 concurrent clients performing a uniform mix of Load, LoadOrStore, Store, and LoadAndDelete on a shared key set and verifies that all observed histories are linearizable. The test surfaces a lost-Store bug: when Store races with LoadAndDelete, the stored value can silently disappear.
jmasters-git
requested review from
JasonChen233,
PureWhiteWu and
xiaost
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request is for demonstrating a skipmap linearizability failure. See reported issue.
Observed timeline
There is no valid linearization of these operations: if
Store(key_0, 200019)linearizes after the first LoadAndDelete, the key should hold 200019. The second LoadAndDelete returning nil means the Store's effect was lost without any corresponding delete.