fix[bsd]: MAP_ANON should be set to -1 , ignored on Linux, required on BSD + go fmt #902
+12
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a panic occurring on FreeBSD (and potentially macOS/other BSDs) where
mmapfails withEINVAL(invalid argument).The Issue
Currently,
mmap_unix.gopasses0as the file descriptor (fd) when callingsyscall.SYS_MMAPwithMAP_ANON.fdargument for anonymous mappings, so passing0works fine.MAP_ANON, which requires thefdto be-1. Passing0results in an immediate crash.Panic Output (FreeBSD):