update jwt dep to fix npm audit issue #175
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GaryGSC
reviewed
Jul 28, 2025
Member
There was a problem hiding this comment.
Looks like tests aren't getting picked up. The ava config previously specified a glob ("test/**/*.spec.ts"), which isn't one of the default patterns for node --test.
Co-authored-by: Gary Crye <[email protected]>
Co-authored-by: Gary Crye <[email protected]>
Member
Author
Thanks for catching that. Fixed. Please review. |
GaryGSC
approved these changes
Jul 28, 2025
Member
GaryGSC
left a comment
GaryGSC
left a comment
There was a problem hiding this comment.
Approving to get out of the way. 🙂
Tests are being run and are passing. Linting also looks clean. Test files only had minimal changes, which leads me to believe we're not making any breaking changes.
Nit: test results are now in TAP format.
jvisker
approved these changes
Jul 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make this change, this PR needed to update the tests to run on node's native test runner.