fix the errorIfExists keywords not match for DSLSQLLexer#1908
Open
hellozepp wants to merge 1 commit intobyzer-org:masterfrom
Open
fix the errorIfExists keywords not match for DSLSQLLexer#1908hellozepp wants to merge 1 commit intobyzer-org:masterfrom
hellozepp wants to merge 1 commit intobyzer-org:masterfrom
Conversation
7253712 to
eee6ce9
Compare
Contributor
Author
|
eee6ce9 to
1acb783
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




Issue description
errorIfExists: 'errorIfExists'and a token for the keywordERRORIfExists:'errorIfExists'. However, due to the implementation of CaseChangingStream in Byzer, which converts all characters to lowercase, the keywordERRORIfExistscannot be recognized properly in some contexts.save (overwrite | append | errorIfExists | ignore)*might match the keyword errorIfExists in the subrule instead of the token in some contexts, leading to incorrect parsing.Steps to reproduce
SAVE errorIfExists table_name as.Proposed solution
To resolve this issue, we propose to unify the usage of the errorIfExists keyword by changing the token definition to
ERRORIFEXISTS:'errorifexists'and using the lowercase string literal consistently throughout the DSLSQL grammar.