Skip to content

minor: fix $NOTEBOOK_HOME error#197

Open
chncaesar wants to merge 1 commit intobyzer-org:mainfrom
chncaesar:zjc-fix
Open

minor: fix $NOTEBOOK_HOME error#197
chncaesar wants to merge 1 commit intobyzer-org:mainfrom
chncaesar:zjc-fix

Conversation

@chncaesar
Copy link
Contributor

Change description

This pr fixes incorrect ${NOTBEOOK_HOME} problem in build/startup.sh. ${NOTEBOOK_HOME} should be parent-directory of bin/startup.sh. See screenshot below:
image

Test result

image

@chncaesar chncaesar requested a review from allwefantasy July 30, 2023 03:21
@chncaesar chncaesar marked this pull request as draft July 30, 2023 03:23
@chncaesar chncaesar marked this pull request as ready for review July 30, 2023 03:30
@allwefantasy
Copy link
Contributor

I'm a little curious, why didn't this issue cause Byzer Notebook to fail to start?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants