Draft
Conversation
ryo-ma
reviewed
Jan 30, 2024
|
|
||
| let html = ''; | ||
| res.data.forEach((d) => { | ||
| res.data.forEach((d: any) => { |
Contributor
There was a problem hiding this comment.
anyでなく可能であれば型を定義することはできますでしょうか？
Contributor
There was a problem hiding this comment.
anyに関しては上記だけではないと思いますので他の今回の変更箇所も対応いただければと思います。
ryo-ma
reviewed
Jan 30, 2024
| if (!variable) return defaultValue | ||
| const value = parseFloat(variable) | ||
| if (Number.isNaN(value)) return defaultValue | ||
| return value |
Contributor
There was a problem hiding this comment.
;がないようです。linter、formatterでこの辺りは引っ掛からないんでしたけ。
Contributor
Author
There was a problem hiding this comment.
上記修正致しました。
linter、formatterについては別途定例等で会話させてください。
Contributor
There was a problem hiding this comment.
上記の対象(12行目)だけではないと思います。9~12行目全て;が抜けていると思います。
i-kaneko-abel
force-pushed
the
feature/external-map-support
branch
from
e7b2a79 to
024650d
Compare
This was referenced Feb 1, 2024
Merged
k-oizumi-abel
changed the base branch from
main
to
feature/export-map-component
k-oizumi-abel
changed the base branch from
feature/export-map-component
to
main
i-kaneko-abel
force-pushed
the
feature/external-map-support
branch
from
024650d to
924484e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
主な修正点は以下。
ブランチ名変更に伴い過去のコメントは以下
#32