-
Notifications
You must be signed in to change notification settings - Fork 4
利活用方法承認時の画面遷移修正 #349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ichimiya1234
wants to merge
77
commits into
main
Choose a base branch
from
refactor/utilization-approval-screen-transition
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
利活用方法承認時の画面遷移修正 #349
ichimiya1234
wants to merge
77
commits into
main
from
refactor/utilization-approval-screen-transition
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d improving configuration retrieval. Implement custom package search for sorting by downloads and likes, and update dataset indexing to include download and like counts. Refactor helper methods for better configuration management and error handling.
…unused moral check log asset from webassets.yml
…e counts. Implemented dynamic configuration loading and event handling for sort selection.
…date steps for CKAN extension installation
… importance of specifying the path
…ack configuration
…dexing downloads and likes
…fields command for better clarity
…de clarity and consistency
…arity and structure of module utilization tables
…quirements for initial installation, sorting feature activation, and updates
…ecifying the need for Like and Download modules
…m sort feature and clarify complete rollback procedures
…a fields for custom sort functionality and provide usage scenarios
…ownloads, and clarify module requirements
…ing dataset indexing
…xing duration and clarify execution scenarios
…nk to official CKAN documentation
…ating the extension
…ed resource management
…w URL method for improved functionality
…ate for improved approval workflow
…oved redirect handling for approval workflow
…utilization URLs with optional parameters
…date URL generation with various parameters]
…enarios for comment handling and error management
…ion_details_url and enhance test setup in TestUtilizationController
…est coverage and setup
…nd maintainability
…nd maintainability
…ying based on name and is_organization status
…y for organization filtering and improve exception handling
…ude dynamic organization name checks and ensure invalid filters are dropped for security
…nization filter handling and exception scenarios
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
概要
利活用方法詳細画面での承認する際の画面遷移を修正しました。
フィードバック管理画面から利活用方法の投稿内容から詳細画面に遷移し、承認ボタンを押下したら再度フィードバック管理画面に遷移するように修正しました。
主な修正点
主な追加・修正ファイル
ckanext/feedback/controllers/utilization.pyckanext/feedback/services/utilization/details.pyckanext/feedback/templates/utilization/details.htmlckanext/feedback/tests/services/utilization/test_details.pyckanext/feedback/tests/controllers/test_utilization.py