reduce scope again: remove structured concurrency-based fibers #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's complicated and hard to use in practice, because it's not obvious if a piece of code is running under another fiber or not, so `Fiber.spawn` might fail because it has no parent. So in practice we've been using `Fiber.spawn_top`… which has no interest over just using `Fut.spawn`.
c-cube
force-pushed
the
simon/reduce-scope-round2
branch
from
4b9e480 to
95de0e7
Compare
c-cube
force-pushed
the
simon/reduce-scope-round2
branch
from
89b8ed3 to
997d996
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For structured concurrency, maybe use picos. For the rest,
Fut.tnow has local storage (like any task).close #29