Continue on fail when max_fail is gt 0

[Pat-Lafon]

I think I ran into #182, where I want to set max_fail to be some value greater than 1.

In my limited sleuthing, I believe the check could have been accidentally removed in 3a9bf2e#diff-07dbdff6f84a44f565ad4871c5790ad598ceda123f0b8190a711d303d3be28efR1718-R1720 (Hmm, it's highlighted in the link, but it doesn't automatically go to the corresponding line number which is 1767 in file src/core/QCheck2.ml). Here, it use to be that if some small parameter and state.cur_max_fail > 0, then it would continue otherwise yield. I've just added that latter back in. In the current codebase, it doesn't seem like cur_max_fail does anything(4 matches for searching this keyword).

Besides just running this locally and seeing that in my example I can report multiple failures in the failure column, I haven't looked into how to test this. I also haven't confirmed is this actually solves #182 other than seeing that the suspected commit was in April 2021 and the issue was filed in September 2021

[jmid]

Thanks a bunch for digging into this issue and suggesting a fix 🙏 🙂

I've added a couple of tests, filed updated expect test outputs for 32+64 bit builds, and added a CHANGELOG entry.

[Pat-Lafon]

Thanks for adding tests! All seems good to me.

[jmid]

Cool, thanks again 🙂