Remove default scope layer for desugaring #106
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When desugaring introduces a `K"Identifer"` it should always decorate it with an associates scope layer - either adopted from the users code, or an internal layer created on the fly. This ensures desugaring treats hygiene consistently with macro expansion (thus ensuring that desugaring itself is hygienic).
mlechu
approved these changes
Oct 21, 2025
There was a problem hiding this comment.
Thanks! It makes sense to delete this "layer." I'm not sure if there's any place in desugaring where generating internal layers is preferable to creating internal Bindings, but I'm not going to make early claims about the land of edge cases.
Going to do a quick merge so I can work on top of this in #99.
The main difference is that the scope analysis pass processes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When desugaring introduces a
K"Identifer"it should always decorate it with an associates scope layer - either adopted from the users code, or an internal layer created on the fly.This ensures desugaring treats hygiene consistently with macro expansion (thus ensuring that desugaring itself is hygienic).