Remove use of JuliaSyntax DOTOP_FLAG and is_dotted
#18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
Any reason to apply this change first? My intent was to try and get #10 merged first, then git-wrangle other changes into more polished/manageable PRs. |
Owner
Author
|
Not really necessary, but it makes #10 work with the latest JuliaSyntax dev branch so I thought I could get it merged as a small step to sorting out the mess of branches 😅 |
Closed
These have been removed upstream on the main branch and replaced with a small number of new `Kind`s.
One test here depends on GreenNode printing which prints the raw flags. An update to JuliaSyntax will fix that soon.
These won't work with the new `CodeInfo`, so it's pointless to run our tests on them, for now. At some point it might make sense to make the non-eval related parts of JuliaLowering work on older versions for use by tooling packages, but it's unclear this is practical.
c42f
force-pushed
the
caf/juliasyntax-dev-fixes
branch
from
63aa9b2 to
3514388
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These have been removed upstream on the main branch and replaced with a small number of new
Kinds.@mlechu I cherry picked this change from one of your other branches and separated them out from other things - you're set as the commit author :-)
Am slowly trying to untangle the mess of PRs we've gotten into with me being away 😅