Fix IR generation for return in value position
#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`return` in value position is allowed in Julia so that ASTs compose more easily.
mlechu
approved these changes
Aug 22, 2025
Collaborator
mlechu
left a comment
mlechu
left a comment
There was a problem hiding this comment.
Looks great, thank you for the fix!
aviatesk
pushed a commit
to mlechu/JuliaLowering.jl
that referenced
this pull request
Aug 22, 2025
`return` in value position is allowed in Julia so that ASTs compose more easily.
Collaborator
|
Happy this issue got fixed so quickly! We use patterns like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #46
(Got broken with the
opargument added in #10 but I hadn't written a test case for this code path 😅)