Fixes for quote interpolation in Expr compat mode #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that interpolating values into quoted expressions works in Expr compat mode. * To produce `Expr` in `CodeInfo` conversion, add an `as_Expr` attribute to `K"inert"`. expand_quote * In analogy with `eval()`, add `expr_compat_mode` keyword to `include_string`. We may want to rethink this when we rethink how options to `eval()` work. * Adapt the runtime function `interpolate_ast` to work with both `Expr` and `SyntaxTree` as the source expression. * Allow `Symbol` to be interpolated into `SyntaxTree` as syntax rather than a `K"Value": Even in "new style macro mode", `:x` is interpreted as a `Symbol` rather than an AST as it's used by many packages as a kind of lightweight untyped enum (ie, a usage which is almost entirely unrelated to AST manipulation) * Fix `SyntaxTree->Expr` conversion so that embedded Expr `K"Value"` means a leaf, not an embedded tree.
mlechu
approved these changes
Aug 29, 2025
|
Awesome, thanks for the extra testing :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that interpolating values into quoted expressions works in Expr compat mode.
ExprinCodeInfoconversion, add anas_Exprmeta attribute toK"inert"generated byexpand_quote. I left this as a meta attribute because it doesn't need to be strongly typed.eval(), addexpr_compat_modekeyword toinclude_string. We may want to rethink this when we rethink how options toeval()work.interpolate_astto work with bothExprandSyntaxTreeas the source expression.Symbolto be interpolated intoSyntaxTreeas syntax rather than aK"Value": Even in "new style macro mode",:xis interpreted as aSymbol` rather than an AST as it's used by many packages as a kind of lightweight untyped enum (ie, a usage which is almost entirely unrelated to AST manipulation)SyntaxTree->Exprconversion so that embedded ExprK"Value"means a leaf, not an embedded tree.Follows up on #44, in particular, resolves the comment at #44 (comment)_
In terms of the implementation, I tried the alternative of keeping
SyntaxTreein theCodeInforather thanExprand using that as the reference expression ininterpolate_ast- I had hoped this might be cleaner and less effort. However, this approach ends up needing a "partial" non-recursive implementation ofExpr->SyntaxTreeconversion (in particular, one where child nodes have already been converted) and that would have required more changes on theJuliaSyntaxside than I wanted. However, we might need that kind of non-recursive machinery in the future. For example, for customizing SyntaxTree->Expr conversion - if we do, we can reconsider the implementation ofinterpolate_astat that point.