Skip to content

Fix Playwright tests that did not include several last minute changes#188

Merged
PascalinDe merged 7 commits intostudent25spring_access_controlfrom
fix-playwright
Feb 19, 2025
Merged

Fix Playwright tests that did not include several last minute changes#188
PascalinDe merged 7 commits intostudent25spring_access_controlfrom
fix-playwright

Conversation

@PascalinDe
Copy link
Member

@PascalinDe PascalinDe commented Feb 18, 2025

Changes that were forgotten to include:

  • ballot API changed
  • build information was updated
  • unauthenticated users cannot access the election forms at all anymore
  • the userIDs are batched in the addVoters API

@PascalinDe PascalinDe requested review from MeKHell and ineiti February 18, 2025 16:23
@PascalinDe PascalinDe changed the base branch from main to student25spring_access_control February 18, 2025 16:23
@PascalinDe
Copy link
Member Author

@MeKHell to fix the build test you need to add the new lines from .env.example to your local .env and restart the frontend container 🙂

Copy link
Member

@ineiti ineiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@MeKHell MeKHell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PascalinDe PascalinDe merged commit 6d16002 into student25spring_access_control Feb 19, 2025
4 of 5 checks passed
@PascalinDe PascalinDe deleted the fix-playwright branch February 19, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants