Skip to content

Convert html project tabs to template#252

Closed
ineiti wants to merge 1 commit intolocal_logo_imagesfrom
html_to_template
Closed

Convert html project tabs to template#252
ineiti wants to merge 1 commit intolocal_logo_imagesfrom
html_to_template

Conversation

@ineiti
Copy link
Member

@ineiti ineiti commented Jan 16, 2026

The html project pages contained references to the images using showcase_v2 as the base url, but that doesn't work with local testing. According to Claude, the solution is to use NuxtImg, but this needs templates and not html.

To be merged after #251

@ineiti ineiti force-pushed the html_to_template branch 2 times, most recently from 3bb9176 to b501ba8 Compare January 16, 2026 15:56
@ineiti ineiti requested review from PascalinDe January 16, 2026 17:05
@ineiti ineiti self-assigned this Jan 16, 2026
@github-project-automation github-project-automation bot moved this to Active Tasks in Engineer's TODO Jan 16, 2026
@ineiti ineiti moved this from Active Tasks to Ready4Review in Engineer's TODO Jan 16, 2026
@ineiti ineiti force-pushed the local_logo_images branch from 997a69a to c2c6191 Compare January 20, 2026 07:52
The html project pages contained references to the images using showcase_v2 as the
base url, but that doesn't work with local testing.
According to Claude, the solution is to use NuxtImg, but this needs templates and not html.
@PascalinDe
Copy link
Member

hm, not sure I agree with this, I'll have a closer look later today

@PascalinDe
Copy link
Member

I find this very confusing, let's talk about it tomorrow

@ineiti
Copy link
Member Author

ineiti commented Jan 21, 2026

I find this very confusing, let's talk about it tomorrow

As discussed, this is mostly about being able to have <NuxtImg and then having automatic insertion of the correct path, based on the baseURL given to nuxt.

I'll try to simplify

https://github.com/c4dt/showcase_v2/pull/252/changes#diff-3dab3823a55489d0b834f1e744910ae51124cfbcb248d5b928fe9bdda36f1076R71

and check if the <template> is necessary in the templates.

@PascalinDe
Copy link
Member

PascalinDe commented Jan 22, 2026

I find this very confusing, let's talk about it tomorrow

As discussed, this is mostly about being able to have <NuxtImg and then having automatic insertion of the correct path, based on the baseURL given to nuxt.

I'll try to simplify

https://github.com/c4dt/showcase_v2/pull/252/changes#diff-3dab3823a55489d0b834f1e744910ae51124cfbcb248d5b928fe9bdda36f1076R71

and check if the <template> is necessary in the templates.

I looked into it yesterday evening, I think the correct way to go about it would be to manually convert the files to components once (instead of doing it programmatically each time), and then use the map from the pull request to include the correct one

@ineiti
Copy link
Member Author

ineiti commented Jan 22, 2026

Follow-up from the matrix chat:

is it possible to have markdown files?

what are the restrictions / possibilities for components? Is it similar to a template?

@PascalinDe
Copy link
Member

Follow-up from the matrix chat:

is it possible to have markdown files?

what are the restrictions / possibilities for components? Is it similar to a template?

a component contains a template

the idea behind components is that you can include them in multiple places

basically all that would be to do is to move the files into the components directory, and change lines 46-48 in Tabs.vue to include the right component based on tab.id, maybe re-using some of the code in getTabComponent

@PascalinDe
Copy link
Member

but as discussed in the chat, the actual solution is to set NUXT_APP_BASE_URL=/showcase_v2/ in nuxt.config.ts

@PascalinDe
Copy link
Member

Follow-up from the matrix chat:
is it possible to have markdown files?
what are the restrictions / possibilities for components? Is it similar to a template?

a component contains a template

the idea behind components is that you can include them in multiple places

basically all that would be to do is to move the files into the components directory, and change lines 46-48 in Tabs.vue to include the right component based on tab.id, maybe re-using some of the code in getTabComponent

(which would add a lot of single-use components hence why it was not done like this in the first place)

@ineiti
Copy link
Member Author

ineiti commented Jan 22, 2026

Closed in favor of #259

@ineiti ineiti closed this Jan 22, 2026
@github-project-automation github-project-automation bot moved this from Ready4Review to Done in Engineer's TODO Jan 22, 2026
@ineiti ineiti deleted the html_to_template branch January 22, 2026 12:45
@PascalinDe PascalinDe restored the html_to_template branch January 23, 2026 16:41
@PascalinDe PascalinDe deleted the html_to_template branch January 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants