Conversation
rock3r
force-pushed
the
fix-canvas-aspect-ratio
branch
from
7ca72e7 to
83f5968
Compare
c5inco
left a comment
c5inco
left a comment
There was a problem hiding this comment.
Left a couple comments. Overall, very welcome changes but need to fix the sizing issue mentioned.
| } | ||
| ) | ||
| .thenIf(canvasSizeMode == DimensionMode.Fixed) { | ||
| aspectRatio(canvasAspectRatio) |
There was a problem hiding this comment.
While this maintains aspect ratio, doesn't behave as expected when setting the size to be smaller than the available space. It also seems to break the double click action to hide/show the points.
It works as expected if setting the size Modifier directly (with the canvasWidth and canvasHeight respectively).
There was a problem hiding this comment.
doesn't behave as expected when setting the size to be smaller than the available space
It works as I expected it to :D That is, take up as much space as possible for the preview. This solves issues with having to implement zoom levels, too, for cases where the canvas is too small to be worked on. If you set the size directly, then you need to implement panning and zooming for when the canvas is too small or large, I reckon, and I didn't want to have to do it
There was a problem hiding this comment.
Forgot:
It also seems to break the double click action to hide/show the points
Works for me — at least when double clicking on the preview canvas. Not elsewhere (but that was already the case before, if you made the canvas non-fill, and small enough to fit in the viewport)
Screen.Recording.2025-03-07.at.16.37.59.mov
There was a problem hiding this comment.
This solves issues with having to implement zoom levels, too, for cases where the canvas is too small to be worked on. If you set the size directly, then you need to implement panning and zooming for when the canvas is too small or large, I reckon, and I didn't want to have to do it
Gotcha. I would prefer to reflect the size at 100% even if it's too small to work with in some situations. Currently I find it confusing when I set it to a smaller size than the available space and visually feels to be roughly the same size. Maybe if we had a label that expressed what zoom level it is at, it would be clearer.
Screen.Recording.2025-03-07.at.21.02.56.mov
To that end, I think we will need zoom levels at some point so I would prefer to fix this sizing issue then.
There was a problem hiding this comment.
Forgot:
It also seems to break the double click action to hide/show the points
Works for me — at least when double clicking on the preview canvas. Not elsewhere (but that was already the case before, if you made the canvas non-fill, and small enough to fit in the viewport)
Screen.Recording.2025-03-07.at.16.37.59.mov
Yeah it seems to be fine now. Not sure what was happening when I saw it not working.
composeApp/src/commonMain/kotlin/des/c5inco/mesh/common/MeshGradient.kt
Outdated
Show resolved
Hide resolved
This commit changes the canvas sizing mode; it is now going to either fill available space, or have a fixed size, on both directions. This makes it behave more intuitively, and allows us to properly respect the canvas aspect ratio in the preview. This is reflected in the UI. That change also includes a bunch of cleanup (including addressing Lint complaints) of the project code. It also includes a change to how points are drawn in the gradient, to avoid the points being squashed for non-square canvases. Lastly, it adds an explicit output image size in the export scale selector, allowing a better understanding of what each option means.
rock3r
force-pushed
the
fix-canvas-aspect-ratio
branch
from
83f5968 to
f002f16
Compare
2 participants
This commit changes the canvas sizing mode; it is now going to either fill available space, or have a fixed size, on both directions. This makes it behave more intuitively, and allows us to properly respect the canvas aspect ratio in the preview. This is reflected in the UI.
That change also includes a bunch of cleanup (including addressing Lint complaints) of the project code.
It also includes a change to how points are drawn in the gradient, to avoid the points being squashed for non-square canvases.
Lastly, it adds an explicit output image size in the export scale selector, allowing a better understanding of what each option means.
demo.mp4