[DO NOT MERGE] Switch to @reach/router#90
Conversation
- adds more accessible route transitions - decreases bundle size - supports relative links
88a98d8 to
f90d8cd
Compare
|
This looks great, thanks!
By get it to work, do you mean running the exported site in a local server? The
Yeah, I think it might be nice to hide the internals of routing a bit better, e.g. have a Link component that can be imported from this library. I would guess that switching out the router implementation here will be a major version change |
Yes, I got it to run by removing |
If you'd like. I don't have an opinion either way. Tradeoff seems to be that now you have an API you have to maintain (so if somebody wants to render some router aware |
Hey folks 👋🏼
I talked to @jxnblk and he expressed interest in switching to Reach Router (https://reach.tech/router). A few reasons to do it:
I was surprised how straightforward the migration was, only took an hour or so 😮
A couple todos:
npm run buildto work, (I couldn't get it to work on master either, something about thexo/basename, so I think it's fine? need somebody else to confirm)Linkor any other router APIWhat do you think?