FEATURE: [exchange] add latency metrics tracking for MAX API requests #2395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c9s
reviewed
Jan 27, 2026
c9s
reviewed
Jan 27, 2026
dboyliao
force-pushed
the
dboy/max/v3-metrics
branch
2 times, most recently
from
4764e60 to
29e8893
Compare
c9s
reviewed
Jan 28, 2026
| if errors.As(err, &requestErr) { | ||
| statusCode = requestErr.StatusCode | ||
| } else { | ||
| log.WithError(err).Warn("fail to cast request error to record status code") |
Owner
There was a problem hiding this comment.
if failed, the code will still be 200?
Collaborator
Author
There was a problem hiding this comment.
fixed.
I changed it to 500.
dboyliao
force-pushed
the
dboy/max/v3-metrics
branch
from
29e8893 to
92f83b9
Compare
dboyliao
changed the title
dboyliao
force-pushed
the
dboy/max/v3-metrics
branch
from
92f83b9 to
596e198
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.