-
-
Notifications
You must be signed in to change notification settings - Fork 341
Oncoprinter enable submitting of data in same format as MutationMapper fix #11214 #5145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for cbioportalfrontend ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
@Mukesh-ghildiyal there seem to be changes assocaited with zooming in this PR. Is that intetional? |
@alisman hardly sry for that i am try to creating a new PR for resolving the issue of mutation mapper(zoom functionality) |
@alisman basically earlier i created a PR for oncoprint enable and now i am trying to fix the zoom functionality of mutation but by my mistake this will happen |
10da73f
to
ae04d13
Compare
@alisman now i just reset my commit now u can check my PR |
makeObservable(this); | ||
this.initialize(); | ||
|
||
reaction( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try to avoid using reactions. i believe the user has to click submit button so that should be a good hook to enter into this routine (fetching this data).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure sir ..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the pattern should be that we set the unparsed text to an observable and remoteData references that observable. Then it will recompute any time the text changes.
@Mukesh-ghildiyal this looks great! Could you add a new section for step 1 of the data loading: Since there are two ways of data submission now, do "Oncoprint format" or "MAF Format" (the mutation mapper style format is MAF Format). Then describe expected columns etc Maybe here it is also good to multiple examples: Maybe multiple buttons "Load example data (OncoPrint Format)" "Load Example data (MAF format)" or something like that |
Fix cBioPortal/cbioportal#11214
Describe changes proposed in this pull request:
-a Modified OncoprinterGeneticUtils to support processing of MutationMapper data format
-b Implemented new async function fetchGeneticMutationAnnotation - integrates with Genome Nexus API to enrich mutation data with annotations
-c Converted existing functions to async - including parseGeneticInput and related functions to accommodate asynchronous data fetching
-d Codebase adjustments - made necessary updates to calling functions and dependent logic to work with the new async flow
Checks
Any screenshots or GIFs?
If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>
to determine thatand notify them either through slack or by assigning them as a reviewer on the PR