Skip to content

Conversation

Mukesh-ghildiyal
Copy link

Fix cBioPortal/cbioportal#11214

Describe changes proposed in this pull request:
-a Modified OncoprinterGeneticUtils to support processing of MutationMapper data format

-b Implemented new async function fetchGeneticMutationAnnotation - integrates with Genome Nexus API to enrich mutation data with annotations

-c Converted existing functions to async - including parseGeneticInput and related functions to accommodate asynchronous data fetching

-d Codebase adjustments - made necessary updates to calling functions and dependent logic to work with the new async flow

Checks

  • Has tests or has a separate issue that describes the types of test that should be created. If no test is included it should explicitly be mentioned in the PR why there is no test.
  • The commit log is comprehensible. It follows 7 rules of great commit messages. For most PRs a single commit should suffice, in some cases multiple topical commits can be useful. During review it is ok to see tiny commits (e.g. Fix reviewer comments), but right before the code gets merged to master or rc branch, any such commits should be squashed since they are useless to the other developers. Definitely avoid merge commits, use rebase instead.
  • Is this PR adding logic based on one or more clinical attributes? If yes, please make sure validation for this attribute is also present in the data validation / data loading layers (in backend repo) and documented in File-Formats Clinical data section!

Any screenshots or GIFs?

If this is a new visual feature please add a before/after screenshot or gif
here with e.g. Giphy CAPTURE or Peek

Notify reviewers

Read our Pull request merging
policy
. It can help to figure out who worked on the
file before you. Please use git blame <filename> to determine that
and notify them either through slack or by assigning them as a reviewer on the PR

Copy link

netlify bot commented Mar 24, 2025

Deploy Preview for cbioportalfrontend ready!

Name Link
🔨 Latest commit ae04d13
🔍 Latest deploy log https://app.netlify.com/sites/cbioportalfrontend/deploys/67eeb991a5e80e00084ac9bb
😎 Deploy Preview https://deploy-preview-5145.preview.cbioportal.org
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@alisman
Copy link
Collaborator

alisman commented Apr 3, 2025

@Mukesh-ghildiyal there seem to be changes assocaited with zooming in this PR. Is that intetional?

@Mukesh-ghildiyal
Copy link
Author

@alisman hardly sry for that i am try to creating a new PR for resolving the issue of mutation mapper(zoom functionality)

@Mukesh-ghildiyal
Copy link
Author

@alisman basically earlier i created a PR for oncoprint enable and now i am trying to fix the zoom functionality of mutation but by my mistake this will happen

@Mukesh-ghildiyal
Copy link
Author

@alisman now i just reset my commit now u can check my PR

makeObservable(this);
this.initialize();

reaction(
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try to avoid using reactions. i believe the user has to click submit button so that should be a good hook to enter into this routine (fetching this data).

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure sir ..

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the pattern should be that we set the unparsed text to an observable and remoteData references that observable. Then it will recompute any time the text changes.

@alisman alisman requested a review from inodb June 5, 2025 15:15
@inodb
Copy link
Member

inodb commented Jun 5, 2025

@Mukesh-ghildiyal this looks great!

Could you add a new section for step 1 of the data loading:

image

Since there are two ways of data submission now, do "Oncoprint format" or "MAF Format" (the mutation mapper style format is MAF Format). Then describe expected columns etc

Maybe here it is also good to multiple examples:

image

Maybe multiple buttons "Load example data (OncoPrint Format)" "Load Example data (MAF format)" or something like that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Oncoprinter enable submitting of data in same format as MutationMapper
3 participants