Gene Specific Chart Comparison Page frontend #5378
Open
i-am-leslie wants to merge 1 commit intocBioPortal:masterfrom
Open
Gene Specific Chart Comparison Page frontend #5378i-am-leslie wants to merge 1 commit intocBioPortal:masterfrom
i-am-leslie wants to merge 1 commit intocBioPortal:masterfrom
Conversation
alisman
reviewed
Feb 5, 2026
| clinicalAttributeValues: ClinicalDataCountSummary[], | ||
| statusCallback: (phase: LoadingPhase) => void | ||
| ): Promise<string> { | ||
| statusCallback(LoadingPhase.DOWNLOADING_GROUPS); |
Collaborator
There was a problem hiding this comment.
@i-am-leslie this stretch of code is pretty hairy. see if you can use some of the lodash helpers groupBy, keyBy etc. to simplify this. in particular look for ways to use assignment instead of declaration and addition. i.e. var result = _.groupBy(...)
Collaborator
There was a problem hiding this comment.
there are sometimes edge cases where it won't work, but should look. and i must say, that this is where AI really shines. just ask it for suggestsions about how to simplify long stretches of code. it will also add nice comments that help a reader.
2687b26 to
9274874
Compare
4228039 to
0473eb4
Compare
Optimization to how groupsamples are created; by using the sample unique id we can create sampleidentifier
d607f22 to
8118bc3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cBioPortal/cbioportal#11771
Describe changes proposed in this pull request:
This pull request introduces frontend updates to support accurate comparison for gene-specific mutation charts and enables a comparison button for gene-specific charts
Checks
Any screenshots or GIFs?
Before
After
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR