Fix Survival Attribute unable to render Group Logic (#11935)#5383
Open
kunalhemnani1 wants to merge 3 commits intocBioPortal:masterfrom
Open
Fix Survival Attribute unable to render Group Logic (#11935)#5383kunalhemnani1 wants to merge 3 commits intocBioPortal:masterfrom
kunalhemnani1 wants to merge 3 commits intocBioPortal:masterfrom
Conversation
onursumer
force-pushed
the
fix/survival-attribute-group-logic
branch
from
48ad63e to
89e8159
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes Study View “User Selections” rendering for certain clinical filters whose attribute IDs end with _STATUS (e.g., ER_STATUS / HER2_STATUS) and were incorrectly treated as survival attributes for attributesMetaSet lookup, causing Group Logic pills to not render.
Changes:
- Add a fallback lookup for
chartMetainUserSelections.renderClinicalDataFiltersto use the originalclinicalDataFilter.attributeIdwhen the derived survival chart meta ID key isn’t found.
dippindots
reviewed
Feb 12, 2026
kunalhemnani1
force-pushed
the
fix/survival-attribute-group-logic
branch
from
89e8159 to
7b4469e
Compare
* Fixes Group Logic for Survival Attribute like ER Status and HER2 Status not appearing when applied filter * Add fallback to chartMeta lookup
* Fixes Group Logic for Survival Attribute like ER Status and HER2 Status not appearing when applied filter * Resolves survival attributeId by checking attributesMetaSet existence before assignment
dippindots
force-pushed
the
fix/survival-attribute-group-logic
branch
from
dcd0f6d to
be34508
Compare
Collaborator
|
@kunalhemnani1 It looks good to me, I just rebased your PR. When we see tests are passing, I will merge it. Thanks! |
Contributor
Author
|
Thanks for the review appreciate you taking the time to look through my changes!
|
* Fixes Group Logic for Survival Attribute like ER Status and HER2 Status not appearing when applied filter * Resolves survival attributeId by checking attributesMetaSet existence before assignment * Fix arm-level CNA filters not appearing when loaded via URL (#11976) * Correct generic assay BINARY/CATEGORICAL dataType comparison to ensure charts render properly
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes cBioPortal/cbioportal#11935 and cBioPortal/cbioportal#11976
Fixes Group Logic for Survival Attribute like ER Status and HER2 Status not appearing when applied filter
Changes proposed in this pull request:
For a detailed breakdown of the issue and the proposed solution, please refer to [BUG] some clinical filters get applied but don't show up as a chip cbioportal#11935 (comment)
Checks
Any screenshots or GIFs?
Before :
After :
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR