Fix 500 error when genomicDataFilters is empty (#11206)#11876
Open
heathdutton wants to merge 1 commit intocBioPortal:masterfrom
Open
Fix 500 error when genomicDataFilters is empty (#11206)#11876heathdutton wants to merge 1 commit intocBioPortal:masterfrom
heathdutton wants to merge 1 commit intocBioPortal:masterfrom
Conversation
onursumer
reviewed
Dec 24, 2025
| // If genomicDataFilters is null or empty, return an empty result list | ||
| // This prevents IndexOutOfBoundsException in the MyBatis mapper | ||
| if (genomicDataFilters == null || genomicDataFilters.isEmpty()) { | ||
| return new ResponseEntity<>(Collections.emptyList(), HttpStatus.OK); |
Member
There was a problem hiding this comment.
Might be better to use the ok method here as well for consistency.
Suggested change
| return new ResponseEntity<>(Collections.emptyList(), HttpStatus.OK); | |
| return ResponseEntity.ok(Collections.emptyList()); |
|
|
||
| /** | ||
| * Test that fetchGenomicDataCounts returns empty list when genomicDataFilters is empty. | ||
| * This verifies the fix for Issue #11206. |
Member
There was a problem hiding this comment.
we probably don't need this line of comment with issue reference. same applies to the other tests below.
63792bb to
ee7d375
Compare
alisman
approved these changes
Jan 5, 2026
When genomicDataFilters is null or empty, return an empty list instead of throwing IndexOutOfBoundsException.
ee7d375 to
54774f4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11206
Describe changes proposed in this pull request:
genomicDataFiltersinfetchGenomicDataCountsandfetchMutationDataCountsendpointsMyBatismapperChecks
Any screenshots or GIFs?
NA
Notify
@alisman @inodb