Fix 500 error when user has no data access token#11953
Open
Annu881 wants to merge 2 commits intocBioPortal:masterfrom
Open
Fix 500 error when user has no data access token#11953Annu881 wants to merge 2 commits intocBioPortal:masterfrom
Annu881 wants to merge 2 commits intocBioPortal:masterfrom
Conversation
- Modified getDataAccessToken to check if token list is empty - If empty, create a new token instead of throwing IndexOutOfBoundsException - Added test case testGetDataAccessTokenWhenNoTokensExist to verify fix Fixes cBioPortal#11905
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Fixes #11905
Fix # (see https://help.github.com/en/articles/closing-issues-using-keywords)
Describe changes proposed in this pull request:
getDataAccessToken(String username)method inUuidDataAccessTokenServiceImpl.javato check if the list of tokens is empty before accessing elementscreateDataAccessToken(username)to generate a new tokentestGetDataAccessTokenWhenNoTokensExistto verify the fix handles the empty token list scenario correctly.Checks
Any screenshots or GIFs?
Not applicable - this is a backend bug fix with no UI changes.
Notify reviewers
@inodb @mavwolverine