fix(#11963): Migrate StudyViewControllerTest to JUnit 5 and fix ignored tests #11964
Open
purvanshjoshi wants to merge 4 commits intocBioPortal:masterfrom
Open
fix(#11963): Migrate StudyViewControllerTest to JUnit 5 and fix ignored tests #11964purvanshjoshi wants to merge 4 commits intocBioPortal:masterfrom
purvanshjoshi wants to merge 4 commits intocBioPortal:masterfrom
Conversation
… fix ignored tests
There was a problem hiding this comment.
Pull request overview
This PR migrates StudyViewControllerTest from JUnit 4 to JUnit 5 and fixes two previously ignored tests (fetchClinicalDataBinCounts and fetchClinicalDataDensityPlot) that were failing due to incorrect mocking strategies and outdated assertions.
Changes:
- Migrated test class from JUnit 4 to JUnit 5 by updating annotations and imports
- Fixed
fetchClinicalDataBinCountstest by replacing mockedClinicalDataBinUtilandClinicalDataFetcherwith real bean instances, and adding required dependencies (IdPopulator,CustomDataService) - Fixed
fetchClinicalDataDensityPlottest by updating assertions to match the API's sparse response format (which filters out empty bins) and adding CSRF token to resolve 403 Forbidden error
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/test/java/org/cbioportal/legacy/web/StudyViewControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cbioportal/legacy/web/StudyViewControllerTest.java
Outdated
Show resolved
Hide resolved
src/test/java/org/cbioportal/legacy/web/StudyViewControllerTest.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #11963
Describe changes proposed in this pull request:
StudyViewControllerTest.javafrom JUnit 4 to JUnit 5, updating annotations (@ExtendWith,@BeforeEach,@Disabled) and imports.fetchClinicalDataBinCountstest:ClinicalDataBinUtilandClinicalDataFetcherwith real bean instances to verify actual binning logic.IdPopulatorto the test context to support the realClinicalDataBinUtil.CustomDataServiceto resolve dependency issues.fetchClinicalDataDensityPlottest:403 Forbiddenerror by adding.with(csrf())to the mock request builder.StudyViewControllerTestpass successfully.Checks
Notify reviewers
Read our Pull request merging
policy. It can help to figure out who worked on the
file before you. Please use
git blame <filename>to determine thatand notify them either through slack or by assigning them as a reviewer on the PR