-
Notifications
You must be signed in to change notification settings - Fork 68
feat: Add expiresIn
option
#103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
alex9smith
wants to merge
3
commits into
ca98am79:master
Choose a base branch
from
alex9smith:feat/add-expiresin-option
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows users to override the default expiry behavior when using DynamoDB TTL to expire sessions from the table. This would be useful, for example, if they wanted to use a browser session scoped cookie as the session cookie (with no maxAge attribute) but needed a shorter TTL than the default '1 day from now'. If this parameter is not provided then there will be no change to the current behaviour.
Draft
2 tasks
liegeandlief
suggested changes
Jul 2, 2025
liegeandlief
suggested changes
Jul 2, 2025
1983837
to
c689574
Compare
liegeandlief
suggested changes
Jul 2, 2025
c689574
to
2557bbf
Compare
2557bbf
to
825094c
Compare
liegeandlief
suggested changes
Jul 2, 2025
825094c
to
c703835
Compare
liegeandlief
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, nice one for getting it done so quickly 🎸 Hopefully @ca98am79 will be able to take a look soon 🤞
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows users to override the default expiry behavior when using DynamoDB TTL to expire sessions from the table. This would be useful, for example, if they wanted to use a browser session scoped cookie as the session cookie (with no maxAge attribute) but needed a shorter TTL than the default '1 day from now'.
If this parameter is not provided then there will be no change to the current behaviour. I think that means this can be released as a minor version change.