[1.21.10] fix nether pathfinder exception in palette scan#4933
Merged
leijurv merged 1 commit intocabaletta:1.21.10from Dec 23, 2025
Merged
[1.21.10] fix nether pathfinder exception in palette scan#4933leijurv merged 1 commit intocabaletta:1.21.10from
leijurv merged 1 commit intocabaletta:1.21.10from
Conversation
Collaborator
|
Looks good to me. Kinda weird we have to do a linear scan with a predicate, but I just checked an older mc version (because I'm lazy) and at least there the scan isn't that terrible. The array palette has to scan anyway, the registry palette just returns true, the singleton palette doesn't have anything to scan, so the only case where this loses in efficiency at all is the hash map palette. |
ZacSharp
approved these changes
Dec 23, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if air is not in palette, prev code would throw an exception
in pre 1.21.10 baritone the palette is actually resized and edited. which works, but imo its better not to edit the state.