build: support lib.cc #1035
Merged
build: support lib.cc #1035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ken-matsui
reviewed
Nov 14, 2024
Member
|
Please fix CI errors. |
Contributor
Author
Working on it! I think I know what the issue is, luckily. |
ken-matsui
reviewed
Nov 15, 2024
Member
Great, thanks! |
added 3 commits
November 14, 2024 19:41
Member
|
Please fix conflicts. (Note: this was merged) |
# Conflicts: # src/BuildConfig.cc # src/Cmd/Build.cc
ken-matsui
reviewed
Nov 16, 2024
Member
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Almost LG. Let's address some small things. Thanks!
ken-matsui
reviewed
Nov 21, 2024
ken-matsui
reviewed
Nov 23, 2024
Member
|
Please fix conflicts, thank you |
…ding # Conflicts: # src/BuildConfig.cc
ken-matsui
reviewed
Nov 24, 2024
Member
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Sorry for taking long to review!
…ecomes liblibpoac
ken-matsui
reviewed
Dec 12, 2024
Member
ken-matsui
left a comment
ken-matsui
left a comment
There was a problem hiding this comment.
Sorry for the late review. Just small performance tweaks, and then LG. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple implementation for static library building. It functions nearly identically to executable building, except that we look for files named
lib.cc(or the other acceptable C++ extensions) and resolved the dependencies for that file. Instead of linking everything into an executable at the end, we instead usearto build an object archive calledlib<package-name>.a.