fix(semver): avoid one-past-end index, close #1178#1201
Merged
ken-matsui merged 1 commit intomainfrom Jul 25, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an undefined behavior (UB) issue in the ComparatorLexer by replacing direct string array access with a safe curChar() method. The fix prevents out-of-bounds access when checking characters at the current lexer position.
- Adds a safe
curChar()method to VersionLexer that returns '\0' for EOF conditions - Replaces all direct
parser.lexer.s[parser.lexer.pos]accesses withparser.lexer.curChar()calls
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Semver.hpp | Adds the curChar() method to VersionLexer for safe character access |
| src/VersionReq.cc | Replaces direct array access with safe curChar() method calls |
ken-matsui
force-pushed
the
fix-ub-outofbounds-comparator-lexer
branch
from
ee42aa9 to
7ae310a
Compare
ken-matsui
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.