-
-
Notifications
You must be signed in to change notification settings - Fork 35
Update On-demand revalidation docs #1026
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
Remove mention about revalidatePath not being supported
🦋 Changeset detectedLatest commit: 9883fff The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughThis pull request introduces a new documentation file and updates an existing one. The new file ( Changes
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
docs/cache-handler-docs/src/app/usage/on-demand-revalidation/page.mdx (1)
23-27
: Consider clarifying therevalidatePath
caveat.While the caveat correctly explains that
revalidatePath
does not immediately revalidate the cached fetch result, consider adding a brief note about what happens on subsequent requests (e.g., whether stale data is served until revalidation completes) to further aid reader understanding.🧰 Tools
🪛 LanguageTool
[uncategorized] ~27-~27: You might be missing the article “the” here.
Context: ...nually mark the cache as revalidated in Handler'srevalidateTag
method. Later in the ...(AI_EN_LECTOR_MISSING_DETERMINER_THE)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.changeset/twelve-items-allow.md
(1 hunks)docs/cache-handler-docs/src/app/usage/on-demand-revalidation/page.mdx
(1 hunks)
🔇 Additional comments (4)
.changeset/twelve-items-allow.md (2)
1-3
: Correct YAML front matter for changeset.The metadata specifying a patch update for the
@repo/cache-handler-docs
package is correctly formatted and follows the changeset conventions.
5-6
: Clear changeset message.The commit message "Update On-demand revalidation docs" is concise and aligns with the PR title and objectives.
docs/cache-handler-docs/src/app/usage/on-demand-revalidation/page.mdx (2)
3-3
: Updated revalidation description.The revised line now clearly states that Next.js provides a way to revalidate a page or a fetch result on demand, reflecting the updated support now available in the App Router.
17-21
: Improved App Router documentation.The section now correctly highlights that the App Router supports both
revalidatePath
andrevalidateTag
functions, thereby removing the previous limitation. This update aligns well with the current capabilities of Next.js.
Remove mention about
revalidatePath
not being supported in the App Router. It was introduced in #460.Summary by CodeRabbit