core: Show JSON error offsets where possible#7437
Merged
francislavoie merged 1 commit intomasterfrom Jan 15, 2026
Merged
Conversation
mholt
requested changes
Jan 14, 2026
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thanks, this is great!
The linter is complaining about %w, it needs to be %s, or omit .Error().
Another suggestion might be to simply prepend or append something like "offset %d: " if the error type is applicable; for consistency, maybe could avoid repeating error message text.
francislavoie
force-pushed
the
json-err-offset
branch
from
7c99cf3 to
b4d416f
Compare
francislavoie
force-pushed
the
json-err-offset
branch
from
b4d416f to
632ee9b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After doing a bit of clicking around after #7436 I realized Go's
jsonhas a byte offset number for its errors which can be useful for figuring out exactly where a syntax error comes from in a huge JSON file in a pinch.Assistance Disclosure
None