Skip to content

Allow underscore in domain sections #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rmburg wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow underscore in domain sections #50

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c9531b0
Allow `_` in domain sections
rmburg Jan 3, 2026
e5cc21f
Run `tree-sitter generate`
rmburg Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions grammar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,9 +25,9 @@ const PORT_REGEX = /[0-9]{1,5}/;
// syntax correctly. The grammar will compile but it won't match correctly.
const tld = choice(/[a-z][a-z]+/, /xn--[a-z0-9]+/);

// Must start with `a-z`, after the first character `0-9` and `-` are allowed,
// cannot end with a `-`.
const DOMAIN_SECTION_REGEX = /[a-z][a-z0-9\-]*[a-z0-9]+/;
// Must start with `a-z`, after the first character `0-9`, `-`, and `_` are allowed,
// cannot end with a `-` or `_`.
const DOMAIN_SECTION_REGEX = /[a-z][a-z0-9\-_]*[a-z0-9]+/;

// Hostname regex, allows:
// - Domains (example.com)
Expand Down
Loading